Skip to content

[Automated] Update API Surface Area - #16042

Closed
aspire-repo-bot[bot] wants to merge 2 commits into
mainfrom
update-api-diffs
Closed

[Automated] Update API Surface Area#16042
aspire-repo-bot[bot] wants to merge 2 commits into
mainfrom
update-api-diffs

Conversation

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Auto-generated update to the API surface to compare current surface vs latest release. This should only be merged once this surface area ships in a new release.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16042

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16042"

@github-actions

Copy link
Copy Markdown
Contributor

🎬 CLI E2E Test Recordings — 53 recordings uploaded (commit 8f7ac2e)

View recordings
Test Recording
AddPackageInteractiveWhileAppHostRunningDetached ▶️ View Recording
AddPackageWhileAppHostRunningDetached ▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect ▶️ View Recording
AgentInitCommand_DefaultSelection_InstallsSkillOnly ▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig ▶️ View Recording
AllPublishMethodsBuildDockerImages ▶️ View Recording
AspireAddPackageVersionToDirectoryPackagesProps ▶️ View Recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps ▶️ View Recording
Banner_DisplayedOnFirstRun ▶️ View Recording
Banner_DisplayedWithExplicitFlag ▶️ View Recording
Banner_NotDisplayedWithNoLogoFlag ▶️ View Recording
ConfigSetGet_CreatesNestedJsonFormat ▶️ View Recording
CreateAndRunAspireStarterProject ▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle ▶️ View Recording
CreateAndRunEmptyAppHostProject ▶️ View Recording
CreateAndRunJavaEmptyAppHostProject ▶️ View Recording
CreateAndRunJsReactProject ▶️ View Recording
CreateAndRunPythonReactProject ▶️ View Recording
CreateAndRunTypeScriptEmptyAppHostProject ▶️ View Recording
CreateAndRunTypeScriptStarterProject ▶️ View Recording
CreateJavaAppHostWithViteApp ▶️ View Recording
CreateStartAndStopAspireProject ▶️ View Recording
CreateTypeScriptAppHostWithViteApp ▶️ View Recording
DashboardRunWithOtelTracesReturnsNoTraces ▶️ View Recording
DescribeCommandResolvesReplicaNames ▶️ View Recording
DescribeCommandShowsRunningResources ▶️ View Recording
DetachFormatJsonProducesValidJson ▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig ▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted ▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted ▶️ View Recording
GlobalMigration_HandlesCommentsAndTrailingCommas ▶️ View Recording
GlobalMigration_HandlesMalformedLegacyJson ▶️ View Recording
GlobalMigration_PreservesAllValueTypes ▶️ View Recording
GlobalMigration_SkipsWhenNewConfigExists ▶️ View Recording
GlobalSettings_MigratedFromLegacyFormat ▶️ View Recording
InvalidAppHostPathWithComments_IsHealedOnRun ▶️ View Recording
LegacySettingsMigration_AdjustsRelativeAppHostPath ▶️ View Recording
LogsCommandShowsResourceLogs ▶️ View Recording
PsCommandListsRunningAppHost ▶️ View Recording
PsFormatJsonOutputsOnlyJsonToStdout ▶️ View Recording
PublishWithDockerComposeServiceCallbackSucceeds ▶️ View Recording
RestoreGeneratesSdkFiles ▶️ View Recording
RestoreSupportsConfigOnlyHelperPackageAndCrossPackageTypes ▶️ View Recording
RunFromParentDirectory_UsesExistingConfigNearAppHost ▶️ View Recording
SecretCrudOnDotNetAppHost ▶️ View Recording
SecretCrudOnTypeScriptAppHost ▶️ View Recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels ▶️ View Recording
StopAllAppHostsFromAppHostDirectory ▶️ View Recording
StopAllAppHostsFromUnrelatedDirectory ▶️ View Recording
StopNonInteractiveMultipleAppHostsShowsError ▶️ View Recording
StopNonInteractiveSingleAppHost ▶️ View Recording
StopWithNoRunningAppHostExitsSuccessfully ▶️ View Recording
UnAwaitedChainsCompileWithAutoResolvePromises ▶️ View Recording

📹 Recordings uploaded automatically from CI run #24253728286

@github-actions
github-actions Bot force-pushed the update-api-diffs branch 7 times, most recently from bdb40f1 to 57043db Compare April 17, 2026 16:45
@github-actions
github-actions Bot force-pushed the update-api-diffs branch 8 times, most recently from e9ecff7 to 48e97b9 Compare April 25, 2026 16:35
@github-actions
github-actions Bot force-pushed the update-api-diffs branch 3 times, most recently from 9886e9c to b3b7dbb Compare April 28, 2026 17:03
Copilot AI review requested due to automatic review settings April 29, 2026 17:01
@aspire-repo-bot
aspire-repo-bot Bot removed the request for review from Copilot April 29, 2026 17:01

@eerhardt Eric Erhardt (eerhardt) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API review findings — see inline comments for details.

Comment thread src/Aspire.Hosting.Foundry/api/Aspire.Hosting.Foundry.cs
@eerhardt

Copy link
Copy Markdown
Member

API Review Summary

1 error, 1 warning, 0 info across 2 files.

Top areas of concern:

  • Breaking Azure.Network property rename (NameOutputNameOutputReference)
  • High-parameter Foundry tool API that should use options/configuration before stable

Each finding is posted as a separate inline comment for discussion.

…6566)

* [release/13.3] Stabilizing builds in preparation for 13.3 release

- Flip StabilizePackageVersion default to true in eng/Versions.props
- Drop the compute_version_suffix step from ci.yml so PR builds use the stabilized version
- Pin Aspire.AppHost.Sdk import to 13.3.0 in RepoTesting.targets
- Pin all stabilizable Aspire packages to 13.3.0 in Directory.Packages.Helix.props
  (packages whose csproj sets SuppressFinalPackageVersion=true keep $(PackageVersion))
- Skip preview-only AppHosts (Kusto, Foundry, Keycloak, Kubernetes, Maui) in the
  TypeScript polyglot validation script (see #15335)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* [release/13.3] Skip tests blocked by suppressed-package stabilization gap

Two test buckets cannot run on a stabilized branch because they exercise NuGet
restore against Aspire.Hosting.* packages that have SuppressFinalPackageVersion=true
and therefore only ship as prerelease (e.g. 13.3.0-dev.<sha>) — but the stabilized
build asks for >= 13.3.0 stable.

Polyglot SDK Validation:
- Add 'Aspire.Hosting' to the skip list in test-typescript-playground.sh (it
  transitively depends on Aspire.Hosting.Azure.Kubernetes via aspire.config.json).
- Apply the same skip block to test-python-playground.sh and test-java-playground.sh
  (the 13.2 PR only updated the TypeScript script).

Cli.EndToEnd-KubernetesDeploy* (11 files):
- Mark each [Fact] with [ActiveIssue(#15335)]. The proper fix is the dynamic
  version computation tracked by #15335 (PR #15681). When that lands the
  ActiveIssue tags can be removed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 17:00
@aspire-repo-bot
aspire-repo-bot Bot removed the request for review from Copilot April 30, 2026 17:00
@joperezr

Jose Perez Rodriguez (joperezr) commented Apr 30, 2026

Copy link
Copy Markdown
Member

Closing in favor of #16602 (since we snapped and that one is targeting release branch)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants